[ENH] Wire up proto defs for sysdb fork endpoint #4299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Sicheng-Pan
commented
Apr 16, 2025
Comment on lines
-263
to
-276
| if len(segmentpbList) != 3 { | ||
| log.Error("GetCollectionWithSegments failed. Unexpected number of collection segments", zap.String("collection_id", collectionID)) | ||
| return res, grpcutils.BuildInternalGrpcError(fmt.Sprintf("Unexpected number of segments for collection %s: %d", collectionID, len(segmentpbList))) | ||
| } | ||
|
|
||
| scopes := []coordinatorpb.SegmentScope{coordinatorpb.SegmentScope_METADATA, coordinatorpb.SegmentScope_RECORD, coordinatorpb.SegmentScope_VECTOR} | ||
|
|
||
| for _, scope := range scopes { | ||
| if _, exists := scopeToSegmentMap[scope]; !exists { | ||
| log.Error("GetCollectionWithSegments failed. Collection segment scope not found", zap.String("collection_id", collectionID), zap.String("missing_scope", scope.String())) | ||
| return res, grpcutils.BuildInternalGrpcError(fmt.Sprintf("Missing segment scope for collection %s: %s", collectionID, scope.String())) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
note: this is removed because the rust frontend performs the same check after receiving the response
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 task
Sicheng-Pan
force-pushed
the
sicheng/sysdb-fork-proto
branch
from
e451d59 to
70a8d27
Compare
1 task
Sicheng-Pan
force-pushed
the
sicheng/sysdb-fork-proto
branch
from
70a8d27 to
0e5dcf1
Compare
1 task
sanketkedia
reviewed
Apr 18, 2025
| @@ -59,6 +59,11 @@ type UpdateCollection struct { | |||
| Ts types.Timestamp | |||
| } | |||
|
|
|||
| type ForkCollection struct { | |||
| SourceCollectionID types.UniqueID | |||
| TargetCollectionName *string | |||
There was a problem hiding this comment.
nit: why is this *string instead of string? Can it ever be NULL?
There was a problem hiding this comment.
It should not be null. Will fix
sanketkedia
approved these changes
Apr 18, 2025
Sicheng-Pan
force-pushed
the
sicheng/sysdb-fork-proto
branch
from
0e5dcf1 to
436d62d
Compare
1 task
Sicheng-Pan
force-pushed
the
sicheng/sysdb-fork-proto
branch
from
436d62d to
8418e8f
Compare
Sicheng-Pan
force-pushed
the
sicheng/sysdb-fork-proto
branch
from
8418e8f to
077e554
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
table_catalog.goTest plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?